-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix phonetics for 俄 #535
Fix phonetics for 俄 #535
Conversation
@xatier I'm more reluctant accepting this PR and #530. I think it comes to a few things. There's the diminishing return of this type of efforts in the name of fault tolerance—are there evidence that this really helps a Taiwanese Mandarin user? I understand that "this is what the official dictionary says", but anecdotally reading 俄 as ㄜˋ is very typically Taiwanese Mandarin whereas 俄 as ㄜˊ is clearly not. #530 is similar. |
I do not have a strong preference on having these proposed pronunciations for these, either. What I do notice is that we already have a fixed combination from both sides (the concise dictionary form vs. common form) for many characters, providing consistency and fault tolerance is my goal for these PRs. #530 is a great example of this, the current dictionary file is highly inconsistent. As all my previous PRs, feel free to close these them if you find them not providing value for 小麥 users. |
IMHO, I see 亞 and 俄 are very similar to #522, I would like to have both pronunciations if we find them are used with equal frequency. Another approach is to ensure all terms have We can also review them case-by-case, just let me know which terms to exclude. Please let me know which approach you would prefer, and we can start from there. :) |
I like the idea, but let's be a bit more nuanced and conservative—for 亞 I'm comfortable with adding the missing ㄧㄚˇ to the entries that only have the ㄧㄚˋ reading. For 俄 I suggest you only add ㄜˋ to entries that are related to 俄國、俄語系 etc., that is when it's used in a proper name. The thing is that Classical Chinese trems such as 俄頃 are never read with the fourth tone even in Taiwanese Mandarin. |
My thoughts are similar to @lukhnos', and MOE dict actually mentions ㄧㄚˇ and ㄜˋ, especially when ㄜˋ is indeed only for 俄國. |
I believe this page does prefer |
I don't disagree. Just saying that it was ㄜˋ, see https://dict.revised.moe.edu.tw/dictView.jsp?ID=10266&q=1&word=%E4%BF%84. |
I'm not sure if the MOE is adopting Beijing tones, but same experience for me that all these characters are pronounced differently with what I learnt from schools. |
I've updated this PR to include only the additions of Here's the current state of the dictionary:
We have some |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Another approach is to ensure all terms have ㄧㄚˇ and ㄜˋ, but NOT add the concise dictionary forms (ㄧㄚˋ and ㄜˊ) to them while keeping the existing ones without deletions.
I think the PR is good as is, and I think this is the approach we should also use for #530, that is only add the missing variant ㄧㄚˇ entries where there are an existing ㄧㄚˋ.
The concise dictionary prefers
ㄜˊ
, we provide both for fault tolerance.https://dict.concised.moe.edu.tw/dictView.jsp?ID=39379&q=1
俄頃
and俄而
are the exceptions, as they have different meanings.